-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the backfill counter to be manually incremented in edit workflows #956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comments that can get handled with a fast follow
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to handle when the collection is disabled
@@ -57,6 +58,7 @@ function OutlinedToggleButton({ | |||
|
|||
return ( | |||
<ToggleButton | |||
{...props} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine now but this should be at the end to allow a user to override whatever they want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good
Issues
#860
Changes
860
Tests
Manually tested
Automated tests
Screenshots
Capture edit | Binding enabled | Backfill unset
Capture edit | Binding enabled | Backfill set
Capture edit | Binding disabled
Materialization edit | Binding enabled | Backfill unset
Materialization edit | Binding enabled | Backfill set
Materialization edit | Binding disabled