Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the backfill counter to be manually incremented in edit workflows #956

Merged
merged 13 commits into from
Jan 31, 2024
Merged

Enable the backfill counter to be manually incremented in edit workflows #956

merged 13 commits into from
Jan 31, 2024

Conversation

kiahna-tucker
Copy link
Member

@kiahna-tucker kiahna-tucker commented Jan 31, 2024 •
edited
Loading

Issues

#860

Changes

860

  • Add a Backfill section to the right-pane of the binding selector beneath the Resource Configuration section of edit workflows. This section should contain a header, description, and an outlined toggle button to manually increment the backfill counter of a given binding. The button will use the primary color as the fill and outline color and have the label Backfill.

Tests

Manually tested

  • scenarios you manually tested

Automated tests

  • unit testing covered

Screenshots

Capture edit | Binding enabled | Backfill unset

pr_screenshot-956-manual_backfill-capture-edit-unselected

Capture edit | Binding enabled | Backfill set

pr_screenshot-956-manual_backfill-capture-edit-selected

Capture edit | Binding disabled

pr_screenshot-956-manual_backfill-capture-edit-binding_disabled

Materialization edit | Binding enabled | Backfill unset

pr_screenshot-956-manual_backfill-materialization-edit-unselected

Materialization edit | Binding enabled | Backfill set

pr_screenshot-956-manual_backfill-materialization-edit-selected

Materialization edit | Binding disabled

pr_screenshot-956-manual_backfill-materialization-edit-binding_disabled

@kiahna-tucker kiahna-tucker marked this pull request as ready for review January 31, 2024 16:22
@kiahna-tucker kiahna-tucker requested a review from a team as a code owner January 31, 2024 16:22
travjenkins
travjenkins approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments that can get handled with a fast follow

lgtm

travjenkins
travjenkins requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to handle when the collection is disabled

travjenkins
travjenkins reviewed Jan 31, 2024
View reviewed changes
src/components/shared/OutlinedToggleButton.tsx
@@ -57,6 +58,7 @@ function OutlinedToggleButton({

return (
<ToggleButton
{...props}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine now but this should be at the end to allow a user to override whatever they want.

travjenkins
travjenkins approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@kiahna-tucker kiahna-tucker merged commit 7baa3ad into main Jan 31, 2024
3 checks passed
@kiahna-tucker kiahna-tucker deleted the kiahna-tucker/enable-manual-backfill branch January 31, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travjenkins travjenkins travjenkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiahna-tucker @travjenkins